[PATCH] ARM: Allow machine to specify it's own IRQ handlers at run-time

Eric Miao eric.y.miao at gmail.com
Sun Dec 12 09:50:56 EST 2010


On Sun, Dec 12, 2010 at 10:49 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Sun, Dec 12, 2010 at 10:33:01PM +0800, Eric Miao wrote:
>> On Wed, Dec 8, 2010 at 9:41 PM, Russell King - ARM Linux
>> <linux at arm.linux.org.uk> wrote:
>> > On Tue, Dec 07, 2010 at 09:31:11PM +0800, Eric Miao wrote:
>> >> +#ifdef CONFIG_MULTI_IRQ_HANDLER
>> >> +     ldr     r1, =handle_arch_irq
>> >> +     ldr     r0, [r1]
>> >> +     cmp     r0, #0
>> >> +     movne   r0, sp
>> >> +     adrne   lr, BSYM(9997f)
>> >> +     ldrne   pc, [r1]
>> >> +#endif
>> >
>> > You might as well do this:
>> > ...
>
>> +#ifdef CONFIG_MULTI_IRQ_HANDLER
>> +     ldr     r1, =handle_arch_irq
>> +     ldr     r0, [r1]
>> +     cmp     r0, #0
>> +     movne   r0, sp
>> +     adrne   lr, BSYM(9997f)
>> +     ldrne   pc, [r1]
>> +#endif
>
> This looks suspiciously like the old version to me.
>

Yeah, my brain malfunctioned. :-)



More information about the linux-arm-kernel mailing list