[PATCH v7 11/12] davinci: add tnetv107x evm backlight device

Kevin Hilman khilman at deeprootsystems.com
Fri Dec 10 11:56:28 EST 2010


"Nori, Sekhar" <nsekhar at ti.com> writes:

> On Thu, Dec 09, 2010 at 20:28:41, Chemparathy, Cyril wrote:
>> On 12/09/2010 06:00 AM, Nori, Sekhar wrote:
>> > On Thu, Dec 09, 2010 at 14:25:49, Nori, Sekhar wrote:
>> >
>> >> This call should simply return if machine is not tnetv107x EVM.
>> >>
>> >> I didn't follow the entire series but wondering why
>> >> platform device registration should be a late init call.
>> >> Typically the driver probe can be made a late init call
>> >> in case of init sequence dependencies.
>> >
>> > I meant driver init, not probe.
>>
>> This was done to handle driver dependencies, and is meant to be
>> temporary (until a real driver dependency framework comes in).
>>
>> Please see [1] for a bit more of background on changing drivers to use
>> module_init().
>
> Hmm, okay. Please include a check for machine in that case.
>

Sekhar is right.  

Today, we don't (can't) build this machine with others for a couple
reasons, but we're moving towards removing those restrictions, so when
this machine is included in a binary with others, it needs to check.

Thanks,

Kevin



More information about the linux-arm-kernel mailing list