[PATCH 1/3] ASoC: EP93xx I2S and PCM fixes

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Dec 10 10:07:58 EST 2010


On Fri, Dec 10, 2010 at 12:14:18AM +0300, Alexander wrote:

> BTW, it's how original Cirrus's sound driver had done it's work. Cirrus
> programmers had not found a way to overcome this. The datasheets for
> EP93xx series cover everything only briefly... The dumbness of EP93xx's
> DMA is also the reason why we do not have DMA in serial ports and SSP...

> The function I'm talking about is snd_ep93xx_dma2usr_ratio(), as told in
> comments "For audio playback, we convert samples of arbitrary format to
> be 32 bit for our hardware".

This doesn't really answer any of my technical questions about what's
going on here.

Please resubmit with a changelog explaining what the limitations are on
both sides (DMA seems clear but the I2S also needs to be covered) and
makes it clear why the functionality is being reduced like this.  This
will ensure that users understand why the change has been made - right
now it looks like a serious functionality regression is being
introduced so we really should make it clear why this is being done.



More information about the linux-arm-kernel mailing list