[PATCH v2 05/15] ARM: mxs: Add low-level debug UART support

[Uwe Kleine-König]

Hello Shawn,

On Thu, Dec 09, 2010 at 10:02:48AM +0800, Shawn Guo wrote:
> 2010/12/9 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> >> +#ifndef __MACH_MXS_UNCOMPRESS_H__
> >> +#define __MACH_MXS_UNCOMPRESS_H__
> >> +
> >> +#define __MXS_BOOT_UNCOMPRESS
is this used, BTW?

> >> +
> >> +#include <asm/mach-types.h>
> >> +
> >> +static unsigned long uart_base;
> >> +
> >> +#define UART(x) (*(volatile unsigned long *)(uart_base + (x)))
> >> +
> >> +#define DR           0x00
> >> +#define FR           0x18
> >> +#define FR_BUSY              (1 << 3)
> >> +#define FR_TXFE              (1 << 7)
> >> +#define CR           0x30
> >> +#define CR_UARTEN    1
> > Maybe namespace these?  Maybe better define CR_UARTEN as (1 << 0) for
> > consistency?
> >
> Are you expecting namespace "MXS_" or "DUART_" for better?
both?

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |