[PATCH 4/6] arm: mx5: always use __mxc_cpu_type to check cpu type

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Dec 9 03:31:42 EST 2010


Hello Richard,

On Thu, Dec 09, 2010 at 03:52:01PM +0800, Richard Zhao wrote:
> 2010/12/9 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> > On Thu, Dec 09, 2010 at 10:08:34PM +0800, Richard Zhao wrote:
> >> Every SoC in mach-mx5 calls mxc_set_cpu_type to set cpu type.
> > I don't like that.  Your change makes the usage of cpu_is_mx51() for
> > single-machine builds more expensive.
> You're right. I'll add the below like other SoCs:
> #ifdef CONFIG_SOC_IMX51
> ..
> #else
> # define cpu_is_mx51()          (mxc_cpu_type == MXC_CPU_MX51)
> #endif
> 
> can I remove cpu_is_mx53 definition?  because CONFIG_SOC_IMX53 is
> undefined yet. Dinh can add it back when he send out other commits.
yeap

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list