[PATCHv3] support PMIC mc13892

Yong Shen yong.shen at linaro.org
Wed Dec 8 22:27:35 EST 2010


On Thu, Dec 9, 2010 at 1:11 AM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Dec 08, 2010 at 03:26:16PM +0100, Arnaud Patard wrote:
>> >> > +#define MC13892_PWGT1SPI        21
>> >> > +#define MC13892_PWGT2SPI        22
>> >> > +#define MC13892_VCOINCELL       23
>
>> If we move this header into drivers/regulator, how are we supposed to
>> declared regulators in the machine file ?
>
> Oh, fail, yes - with this interface you do need to put the defines where
> the machine driver can see them.
>
Yes, that's the main reason for this. And besides that, there also
possibility for other mc13892 related drivers to use these
definitions, so it should be better in 'include/linux/mfd'.

Yong



More information about the linux-arm-kernel mailing list