[PATCH v3 03/15] ARM: mxs: Add reset routines

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Dec 8 15:31:48 EST 2010


Hi Lothar,

On Wed, Dec 08, 2010 at 08:33:32AM +0100, Lothar Waßmann wrote:
> Hi,
> 
> Shawn Guo writes:
> >  - The mxs wdog is implemented in RTC block.
> >  - There is a generic software reset routine for most modules on mxs.
> > 
> > Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
> > ---
> > Changes for v3:
> >  - Change wdog timeout to 10ms for safety
> >  - Simplify function mxs_reset_block() to get it look better
> > 
> > Changes for v2:
> >  - Move rtc clock enabling from arch_reset() into mxs_arch_reset_init()
> > 
> mxs_arch_reset_init() is currently being called from the .map_io hook
> in mach-mxs/mm-mx23.c and mm-mx28.c which is called before clocks are
> registered.
> But IMO this should be removed from the .map_io hook anyway (as well
> as mxs_iomux_init()).
I assume you want to make this an initcall?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list