[PATCH RFC] arm: Add argument to init_machine

David Brown davidb at codeaurora.org
Wed Dec 8 12:50:00 EST 2010

On Wed, Dec 08, 2010 at 05:27:32PM +0000, Russell King - ARM Linux wrote:

> Well, that depends on how you're going to use this.
> Generally, we find that it's best to arrange the common stuff as
> libraries, and have the platform specific code call the library
> functions to perform the common work.
> Calling a common function from the platform methods and putting
> lots of if (machine_is_xxx()) in it certainly isn't the right method.

The idea is to reduce the machine_is_xxx() calls.  I'll have a clearer
patch soon, but it basically lets us need only one machine init
function for a group of boards, so instead of something like:

	void board1_init(void)

	void board2_init(void)

(or having machine_is_xxx() calls): we end up with

	void board_family_init(void *arg)
		struct board_family_data *priv = arg;


I do share a bit of the concern that the mechanism can be abused, but
I've also found that nearly everything in the board files gets abused.


Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

More information about the linux-arm-kernel mailing list