[PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL
Dave Martin
dave.martin at linaro.org
Wed Dec 8 06:40:13 EST 2010
On Tue, Dec 7, 2010 at 7:29 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Tue, Dec 07, 2010 at 04:50:50PM +0000, Dave Martin wrote:
>> I'll follow up shortly with a patch to the generic ARM Kconfig to make
>> this explicit, so that ARCH_OMAP2 and THUMB2_KERNEL can't accidentally
>> be configured together.
>
> That's a rubbish dependency. You may have an ARCH_OMAP2 platform which
> is Cortex A9, and you only have Cortex A9 support selected. In that
> case there's no reason to prevent THUMB2_KERNEL being selected.
>
> The right thing to do is to make THUMB2_KERNEL depend on those CPUs
> which are not to be selected - not by making it depend on some platform
> configuration option(s) which aren't actually relevent.
>
You're correct on this point-- this was my conclusion also.
If you haven't already, take a look at my other post
http://www.spinics.net/lists/arm-kernel/msg106576.html
Does this address your concern?
Cheers
---Dave
More information about the linux-arm-kernel
mailing list