[PATCH v2 08/15] ARM: mxs: Add iomux support

[Shawn Guo]

2010/12/8 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Hello,
>
> On Wed, Dec 08, 2010 at 06:52:36PM +0800, Shawn Guo wrote:
>> Hi Lothar,
>>
>> Thanks for the review.
>>
>> On Wed, Dec 8, 2010 at 3:25 PM, Lothar Waßmann <LW at karo-electronics.de> wrote:
>> > Hi,
>> >
>> > Shawn Guo writes:
>> >> MXS-based SoCs implements iomux functions in block PINCTRL.
>> >>
>> >> Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
>> >> ---
>> >> Changes for v2:
>> >>  - Define iomux_cfg_t as u64
>> >     ^^^^^^^^^^^^^^^^^^^^^^^^^
>> > Really?
>> >
>> >> +typedef struct pad_desc {
>> >> +     unsigned bank:12;
>> >> +     unsigned pin:20;
>> >> +     unsigned muxsel:8;
>> >> +     unsigned ma:12;
>> >> +     unsigned vol:8;
>> >> +     unsigned pull:4;
>> >> +} iomux_cfg_t;
>> > ^^^^^^^^^^^^^^^^^
>> >
>> I did not pick the correct word.  What I meant is 64 bits.  Since this
>> error is in change log, I would fix it if there is v3 of the patch.
> the idea was to really use an u64 to have the pin definitions modifyable.
>
Ah, I misunderstood the comments.  But I did not see mxc switches to
u64.  Do you have example to show what you want exactly?

-- 
Regards,
Shawn