[PATCH v3 06/15] ARM: mxs: Add timer support

[Uwe Kleine-König]

Hello Lothar,

On Wed, Dec 08, 2010 at 09:30:39AM +0100, Lothar Waßmann wrote:
> > +	switch (mode) {
> > +	case CLOCK_EVT_MODE_PERIODIC:
> > +		printk(KERN_ERR "mxs_set_mode: Periodic mode is not "
> > +				"supported for MXS-based\n");
> >
> Please do not line wrap message strings. Also, if you want the
> function name to appear in the message, use __func__ or __FUNCTION__.
> That way the name is always correct even if the function is renamed or
> the printk() statement is copied to a different function.
__FUNCTION__ isn't considered good, so please use __func__.
(__FUNCTION__ is a gcc extension, __func__ is c99 (I think)).
checkpatch warns about __FUNCTION__, too.

Shawn, you can also consider using pr_err.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |