[PATCH v3 01/15] ARM: mxs: Add core definitions

[Uwe Kleine-König]

On Wed, Dec 08, 2010 at 12:50:56PM +0800, Shawn Guo wrote:
> Hi Uwe,
> 
> 2010/12/8 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> > On Wed, Dec 08, 2010 at 12:31:52AM +0800, Shawn Guo wrote:
> [...]
> >> +#ifndef __MACH_MX23_H__
> >> +#define __MACH_MX23_H__
> >> +
> >> +#ifndef __ASSEMBLER__
> >> +#include <linux/io.h>
> >> +#endif
> > You don't need this, do you?
> >
> It can be removed after adding "#include <linux/io.h>" into icoll.c.
fine

> > #inclusion of hardware.h would be OK, then you could remove the
> > #includes of mx23.h and mx28.h in there.
> > (Believe me, this is better, mxc already made me headaches because of
> > that.)
> >
> I do not get it.  Can you please help me understand what you want
> exactly?  Remove includes of mx23.h and mx28.h from hardware.h, and
> then include mx23.h, mx28.h, hardware.h individually when necessary?
Yeap.  You will need hardware.h for mx2[38].h to get the macros
MXS_IO_P2V and IOMEM.

Best regards
UWe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |