[PATCH v2 04/15] ARM: mxs: Add interrupt support
shawn.gsc at gmail.com
Wed Dec 8 03:56:40 EST 2010
2010/12/8 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Hello Shawn,
>> + .macro disable_fiq
>> + .endm
> I think is isn't needed. Only when you start to actually use the fiq.
Without it, the compiler will complain when compiling
>> + ldr \base, =icoll_base
>> + ldr \base, [\base]
>> +#elif defined (CONFIG_SOC_IMX23)
>> + ldr \base, =MX23_ICOLL_BASE_ADDR
>> + ldr \base, =MX28_ICOLL_BASE_ADDR
> Mhh, you said the base addresses are different. Unless I'm mistaken
> they are not. So you can just remove icoll_base.
Something went wrong in my head. The addresses are same.
More information about the linux-arm-kernel