OMAP2+: PM/serial: hold console semaphore while OMAP UARTs are disabled

Kevin Hilman khilman at deeprootsystems.com
Tue Dec 7 15:59:51 EST 2010


Tony Lindgren <tony at atomide.com> writes:

> * Kevin Hilman <khilman at deeprootsystems.com> [101124 16:32]:
>> Paul Walmsley <paul at pwsan.com> writes:
>
> <snip>
>
>> Acked-by: Kevin Hilman <khilman at deeprootsystems.com>
>> 
>> Very nice.  I've been exploring various solutions to this problem as
>> well, but this one is much cleaner.  Also, I hadn't discovered the 'try'
>> version of the console semaphore, so was running into recursive locking.
>> 
>> Anyways, tested on omap35xx: omap3evm (uart1/core console) and beagle
>> (uart3/per console) and omap34xx/n900 (uart3/per console) using both
>> retention-idle and off-idle.
>
> Thanks, queuing this as fix for the -rc cycle.

FYI.. just found a regression caused by this patch.  It prevented
suspend from ever happening since the console semaphore is already held
during suspend.

Just posted a fix for this:

Date: Tue, 7 Dec 2010 12:24:13 -0800
Subject: [PATCH] OMAP2+: PM/serial: fix console semaphore acquire during suspend


Kevin




More information about the linux-arm-kernel mailing list