[PATCH] OMAP1: I2C: fix device initialization

Cory Maccarrone darkstar6262 at gmail.com
Mon Dec 6 23:34:00 EST 2010


On Mon, Dec 6, 2010 at 8:30 PM, Paul Walmsley <paul at pwsan.com> wrote:
>
> Commit 4d17aeb1c5b2375769446d13012a98e6d265ec13 ("OMAP: I2C: split
> device registration and convert OMAP2+ to omap_device") broke I2C on
> OMAP1.  The following messages appear at boot:
>
> i2c_omap i2c_omap.1: failure requesting irq 0
> i2c_omap: probe of i2c_omap.1 failed with error -22
>
> Investigation revealed that a chunk of code is missing from the
> original plat-omap/i2c.c file which configured the IRQ and base address
> for the I2C block on OMAP1.  Upon adding this back, the OMAP1 I2C block
> seems to initialize correctly.
>
> Thanks to Cory Maccarrone <darkstar6262 at gmail.com> for reporting the bug,
> and apologies for the breakage.
>
> Signed-off-by: Paul Walmsley <paul at pwsan.com>
> Cc: Cory Maccarrone <darkstar6262 at gmail.com>
> Cc: Janusz Krzysztofik <jkrzyszt at tis.icnet.pl>

I tested this on my Herald.  Seems to do the job.

Tested-by: Cory Maccarrone <darkstar6262 at gmail.com>

- Cory



More information about the linux-arm-kernel mailing list