[PATCH] support PMIC mc13892

Yong Shen yong.shen at linaro.org
Mon Dec 6 21:52:17 EST 2010


On Mon, Dec 6, 2010 at 6:55 PM, Arnaud Patard <arnaud.patard at rtp-net.org> wrote:
> <yong.shen at freescale.com> writes:
>
> Hi,
>
>> From: Yong Shen <yong.shen at linaro.org>
>>
>> add support for mc13892, tested on mx51 babbage board
>
> Will review/test it asap on my efikamx. thanks for working on this :)
Welcome, it is also one of my tasks.
>
>>
>> Signed-off-by: Yong Shen <yong.shen at linaro.org>
>> ---
>>  drivers/mfd/Kconfig                   |    4 +
>>  drivers/regulator/Kconfig             |    8 +
>>  drivers/regulator/Makefile            |    1 +
>>  drivers/regulator/mc13892-regulator.c |  647 +++++++++++++++++++++++++++++++++
>>  include/linux/mfd/mc13892.h           |   38 ++
>>  5 files changed, 698 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/regulator/mc13892-regulator.c
>>  create mode 100644 include/linux/mfd/mc13892.h
>
> [...]
>
>> +
>> +static const int mc13892_vvideo[] = {
>> +     2500000, 2600000, 270000, 2775000,
>> +};
>
> Should be :
> static const int mc13892_vvideo[] = {
>        270000, 2775000, 2500000, 2600000,
> };

confirmed by spec. I will update it.

Thanks
Yong
>
> I've spotted this in my code some time ago. VVIDEO voltages are not
> ascending order.
>
>
> Arnaud
>



More information about the linux-arm-kernel mailing list