[PATCH] support PMIC mc13892
Alberto Panizzo
maramaopercheseimorto at gmail.com
Mon Dec 6 06:42:32 EST 2010
On lun, 2010-12-06 at 11:55 +0100, Arnaud Patard wrote:
> <yong.shen at freescale.com> writes:
>
> Hi,
>
> > From: Yong Shen <yong.shen at linaro.org>
> >
> > add support for mc13892, tested on mx51 babbage board
>
> Will review/test it asap on my efikamx. thanks for working on this :)
>
> >
> > Signed-off-by: Yong Shen <yong.shen at linaro.org>
> > ---
> > drivers/mfd/Kconfig | 4 +
> > drivers/regulator/Kconfig | 8 +
> > drivers/regulator/Makefile | 1 +
> > drivers/regulator/mc13892-regulator.c | 647 +++++++++++++++++++++++++++++++++
> > include/linux/mfd/mc13892.h | 38 ++
> > 5 files changed, 698 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/regulator/mc13892-regulator.c
> > create mode 100644 include/linux/mfd/mc13892.h
>
> [...]
>
> > +
> > +static const int mc13892_vvideo[] = {
> > + 2500000, 2600000, 270000, 2775000,
> > +};
>
> Should be :
> static const int mc13892_vvideo[] = {
> 270000, 2775000, 2500000, 2600000,
> };
>
> I've spotted this in my code some time ago. VVIDEO voltages are not
> ascending order.
If this is true, also a private get_best_voltage_index have to be
developed for it.
--
Alberto!
Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)
More information about the linux-arm-kernel
mailing list