[PATCH 22/22] ARM: SMP: remove smp_mpidr.h

Santosh Shilimkar santosh.shilimkar at ti.com
Mon Dec 6 05:47:42 EST 2010


> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Sent: Monday, December 06, 2010 4:02 PM
> To: Santosh Shilimkar
> Cc: linux-arm-kernel at lists.infradead.org; Catalin Marinas
> Subject: Re: [PATCH 22/22] ARM: SMP: remove smp_mpidr.h
>
> On Mon, Dec 06, 2010 at 03:02:09PM +0530, Santosh Shilimkar wrote:
> > Russell,
> > > -----Original Message-----
> > > From: linux-arm-kernel-bounces at lists.infradead.org
[mailto:linux-arm-
> > > kernel-bounces at lists.infradead.org] On Behalf Of Russell King - ARM
> > Linux
> > > Sent: Saturday, December 04, 2010 1:56 AM
> > > To: linux-arm-kernel at lists.infradead.org; Catalin Marinas
> > > Subject: [PATCH 22/22] ARM: SMP: remove smp_mpidr.h
> > >
> > > With "ARM: CPU hotplug: remove bug checks in platform_cpu_die()", we
> > > now do not use hard_smp_processor_id(), we no longer need to read
the
> > > hardware processor ID.  Remove the include providing this function.
> > >
> > hard_smp_processor_id() is also useful when wakeup from low power
> > modes and wants to run specific restore code on specific
> > CPUs. Ofcourse platform have it's own custome macro, but having
> > ARM generic is better.
>
> Maybe, but there's no code in the kernel making use of it.  Also note
> that there is a tendency to compare the kernel's CPU numbers (which are
> the logical numbers) with hard_smp_processor_id() (the physical number)
> which may not always be the same thing.
Agree. May be we can add it when the need arises.



More information about the linux-arm-kernel mailing list