[patch 1/3] mmc, sh: Move MMCIF_PROGRESS_* into sh_mmcif.h

Magnus Damm magnus.damm at gmail.com
Sun Dec 5 19:57:17 EST 2010


On Mon, Dec 6, 2010 at 9:12 AM, Simon Horman <horms at verge.net.au> wrote:
> Allow MMCIF_PROGRESS_* to be shared.
>
> Cc: Magnus Damm <magnus.damm at gmail.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>

I'm a bit hesitant to this change. This because the progress really
hasn't anything to do with the MMCIF hardware block. The enum does use
the MMCIF prefix though, so I guess i should be silent. =)

In the future I can imagine that there will be more boards making use
of this feature, and other MMC/SD-capable hardware blocks that want to
support early loading. Perhaps moving the enum into the header like
you suggest is the easiest way forward. Unless there is any easy way
to share the same progress code between MMCIF and say SDHI.

Thanks,

/ magnus



More information about the linux-arm-kernel mailing list