[PATCH 01/10] SMDK2416: Select MACH_SMDK, S3C_DEV_NAND, S3C_DEV_USB_HOST

[Kukjin Kim]

Yauhen Kharuzhy wrote:
> 
> > > @@ -35,9 +35,12 @@ menu "S3C2416 Machines"
> > >  config MACH_SMDK2416
> > >  	bool "SMDK2416"
> > >  	select CPU_S3C2416
> > > +	select MACH_SMDK
> >
> > No need to add this here.
> 
> SMDK2416 board code uses generic SMDK code, so it should be compiled
> also.
> 
Yeah, I was confused. You're right.

If there is no 'MACH_SMDK', happened following error with only S3C2416
arch/arm/mach-s3c2416/built-in.o: In function `smdk2416_machine_init':
arch/arm/mach-s3c2416/mach-smdk2416.c:193: undefined reference to
`smdk_machine_init'

> > >  	select S3C_DEV_FB
> > >  	select S3C_DEV_HSMMC
> > >  	select S3C_DEV_HSMMC1
> > > +	select S3C_DEV_NAND
> > > +	select S3C_DEV_USB_HOST
> >
> > Probably, did you test NAND and USB_HOST on board?
> Yes, but one year ago. I don't have access to SMDK2416 anymore and usually
> test my patches on another S3C2416 board (e-book reader prototype).
> 
(Added Banajit in To)

Banajit, could you please test this on SMDK2416?

> Without selection of S3C_DEV_NAND & S3C_DEV_USB_HOST mach-smdk2416.c
> doesn't compile, so we should either enable this platform devices
> definitions, either remove this devices from board file.
> 

Yes, if there is no 'S3C_DEV_USB_HOST', happened following error.
arch/arm/mach-s3c2416/built-in.o:(.init.data+0x48): undefined reference to
`s3c_device_ohci'

But I couldn't find 's3c_device_nand' device in mach-smdk2416.c and any
regarding NAND build failure.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.