[PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode

Cousson, Benoit b-cousson at ti.com
Fri Dec 3 07:19:06 EST 2010


On 12/3/2010 10:47 AM, G, Manjunath Kondaiah wrote:
> * Cousson, Benoit<b-cousson at ti.com>  [2010-12-03 09:38:35 +0100]:

[...]

>>> v7: replaced mutex lock with spin lock. Added use count for controlling
>>> access to sysconfig registers in case if overlapping request/release API's
>>> are used.
>>
>> I'm not sure it should be done here. I'd rather keep that code in
>> the DMA, since this is the only user of that feature.
>
> Are you referring to spin lock or usage count?

The spinlock is needed, I was referring to the usage count.

That being said, the API proposed by Paul (request/release
) sound like a get/put, so maybe he had that kind of usage in mind.

I'm still not convince it should be done at hwmod API level.


Paul,
Any thoughts on that?

Regards,
Benoit



More information about the linux-arm-kernel mailing list