[PATCH 2/4] mach-s5pv310: Add resource definitions for mipi-csis

Jassi Brar jassisinghbrar at gmail.com
Fri Dec 3 00:52:23 EST 2010


On Fri, Dec 3, 2010 at 2:34 PM, Kyungmin Park <kyungmin.park at samsung.com> wrote:
> On Fri, Dec 3, 2010 at 1:59 PM, Jassi Brar <jassisinghbrar at gmail.com> wrote:
>>> Sylwester Nawrocki wrote:

>>> +#define S5PV310_PA_CSIS0             (0x11880000)
>>> +#define S5PV310_PA_CSIS1             (0x11890000)
>>
>> Let us please not contain constants in brackets.
>
> I think consistency is more higher than your comment normally.
>
> if you think these, then make a cleanup first.

Bad logic. One shouldn't hold good practice at ransom because of
the past bad ones.



More information about the linux-arm-kernel mailing list