[PATCH] mmci: supply per-instance regulator name

Linus Walleij linus.ml.walleij at gmail.com
Thu Dec 2 08:23:48 EST 2010


2010/12/2 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> On Thu, Dec 02, 2010 at 12:28:27PM +0000, Russell King - ARM Linux wrote:
>
>> The way the MMCI code is, it only requests one regulator per AMBA
>> device, and therefore only one regulator per struct device.  So I
>> don't think the current code needs changing in any way provided the
>> struct device is used to find the corresponding regulator.
>
> Hrm.  In that case I'm not sure what the problem Linus' patch fixes is -
> the driver is already requesting using the struct device, I was assuming
> that the supplies weren't being requested in a fine grained enough
> fashion.

Probably it's the platform board regulator config that needs fixing
instead, so as to bind to the correct device.
I'll check...

I'll do another patch that simply gets rid of the #ifdef for now
instead.

Thanks,
Linus Walleij



More information about the linux-arm-kernel mailing list