[PATCH] mmci: supply per-instance regulator name
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Dec 2 06:57:00 EST 2010
On Thu, Dec 02, 2010 at 12:35:07PM +0100, Linus Walleij wrote:
> On the Ux500 we have different regulators to different card slots
> and eMMCs, and some have no regulator. Move the hardcoded "vmmc"
> regulator name to platform data and supply it that way for the
> platforms that use it. Remove the ugly and unneeded #ifdef around
> the regulator fetch code at the same time.
It seems that the regulator code is making all the same mistakes that
historically were made with the clk API code.
Rather than using the struct device, it's trying to use the regulator
name to distinguish individual sources of supply. This can only lead
to lots of regulator names being passed around from layer to layer,
rather than the now proven cleaner method that the clk API always set
out to do.
I'd like regulator people to think long and hard about the sanity of
passing names all the way from platform code into drivers and back
into the regulator code before I consider this patch any further.
More information about the linux-arm-kernel