[PATCH v4] arm: remove unused code in delay.S

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Sat Sep 19 09:47:31 EDT 2009

Hello Steve,

On Sat, Sep 19, 2009 at 07:55:29AM -0500, Steve Chen wrote:
> Document #if 0 code block in delay.S and make it selectable for compile.
> Signed-off-by: Steve Chen <schen at mvista.com>
> Reviewed-by: Felipe Contreras <felipe.contreras at gmail.com>
> Reviewed-by: Jamie Lokier <jamie at shareable.org>
> Reviewed-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> Reviewed-by: Krzysztof Halasa <khc at pm.waw.pl>
> Reviewed-by: Marek Vasut <marek.vasut at gmail.com>
> Reviewed-by: Pavel Machek <pavel at ucw.cz>
> Reviewed-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
I'm very surprised you added these Reviewed-by: tags.

IMO you should not add them without the explicit permission and request
of the corresponding person.  (That means that at least mine should not
be there.)

Moreover Reviewed-by: has a meaning (described in

Best regards

Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

More information about the linux-arm-kernel mailing list