[PATCH v4] arm: remove unused code in delay.S

Steve Chen schen at mvista.com
Sat Sep 19 08:55:29 EDT 2009

Document #if 0 code block in delay.S and make it selectable for compile.

Signed-off-by: Steve Chen <schen at mvista.com>
Reviewed-by: Felipe Contreras <felipe.contreras at gmail.com>
Reviewed-by: Jamie Lokier <jamie at shareable.org>
Reviewed-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
Reviewed-by: Krzysztof Halasa <khc at pm.waw.pl>
Reviewed-by: Marek Vasut <marek.vasut at gmail.com>
Reviewed-by: Pavel Machek <pavel at ucw.cz>
Reviewed-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>


 arch/arm/Kconfig     |   23 +++++++++++++++++++++++
 arch/arm/lib/delay.S |    2 +-
 2 files changed, 24 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index aef63c8..9a5a49a 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -813,6 +813,29 @@ config ARM_ERRATA_460075
 	  ACTLR register. Note that setting specific bits in the ACTLR
 	  may not be available in non-secure mode.
+	depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
+	bool "Different delay() code for some older CPUs"
+	help
+	  Enable this if observing longer than expected delays.  This code
+	  improves delay accuracy for some CPUs.  However, it can also cause
+	  delay duration to be too short for others which leads to stability
+	  issues.
+	  In other words, do not enable unless you can guarantee that the
+	  processor (or ALL of the processors if building a generic kernel)
+	  delays for at least the time requested after enabling.
+	  ARM610 and ARM710 are known to benefit from enabling this option.
+	  It should not be enabled for StrongARMs, because it is known
+	  to produce too short delays on those.
+	  CPUs should enable this flag
+		ARM610 (rmk)
+		ARM710 (rmk)
+	  CPUs should disable this flag
+		StrongARM (rmk)
 source "arch/arm/common/Kconfig"
diff --git a/arch/arm/lib/delay.S b/arch/arm/lib/delay.S
index 8d6a876..67e679b 100644
--- a/arch/arm/lib/delay.S
+++ b/arch/arm/lib/delay.S
@@ -42,7 +42,7 @@ ENTRY(__const_udelay)				@ 0 <= r0 <= 0x7fffff06
 @ Delay routine
 		subs	r0, r0, #1
-#if 0
 		movls	pc, lr
 		subs	r0, r0, #1
 		movls	pc, lr

More information about the linux-arm-kernel mailing list