[PATCH 08/10] S3C64XX I2S: Return correct codec clock
jassisinghbrar at gmail.com
Wed Sep 16 01:16:54 EDT 2009
On Tue, Sep 15, 2009 at 8:56 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Sep 15, 2009 at 08:21:05PM +0900, jassi brar wrote:
>> On Tue, Sep 15, 2009 at 8:06 PM, Mark Brown
>> > There's three possible clocks here according to the datasheet - PCLK,
>> > CLKAUDIO and I2SCLK - so this will still give the wrong clock some of
>> > the time. Also, please use checkpatch
>> Yes, but the existing code doesn't consider I2SCLK at all.
>> The infra isn't there to provide the clock pointer anyhow.
> Please put a comment there explaining that, or ideally code that returns
> an error in those cases, to make it clearer what's being done.
Wait, there is no option for selecting I2SCLK in the manual. That is
behind the MUX along with Mpll/Epll Out etc.
In the driver we actually have all the correct options : PCLK or
CLKAUDIO(which is the output of the MUX).
The IMS bit can select only either PCLK or CLKAUDIO.So, i guess
the patch is fine as it is.
More information about the linux-arm-kernel