[PATCH 08/10] S3C64XX I2S: Return correct codec clock

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Sep 15 07:56:18 EDT 2009

On Tue, Sep 15, 2009 at 08:21:05PM +0900, jassi brar wrote:
> On Tue, Sep 15, 2009 at 8:06 PM, Mark Brown

> > There's three possible clocks here according to the datasheet - PCLK,
> > CLKAUDIO and I2SCLK - so this will still give the wrong clock some of
> > the time.  Also, please use checkpatch

> Yes, but the existing code doesn't consider I2SCLK at all.
> The infra isn't there to provide the clock pointer anyhow.

Please put a comment there explaining that, or ideally code that returns
an error in those cases, to make it clearer what's being done.

More information about the linux-arm-kernel mailing list