[PATCH v2 1/2] arm: a driver for on-chip ETM and ETB
Russell King - ARM Linux
linux at arm.linux.org.uk
Tue Oct 13 13:47:22 EDT 2009
On Tue, Oct 13, 2009 at 08:06:50PM +0300, Alexander Shishkin wrote:
> + emu_clk = *(struct clk **)pdev->dev.platform_data;
> + if (emu_clk)
> + clk_enable(emu_clk);
Definitely no way this is going to be acceptable. Never EVER pass clk
pointers around like this.
And you've ignored the comments about it being a platform driver.
Sorry, but the answer to this patch is a firm NAK.
Please make it an AMBA primecell driver. Also make it follow the clk
API correctly, and claim the three clocks for that primecell *only*.
More information about the linux-arm-kernel