[PATCH v1.0 2/4] TS72XX: Allow to override machine ID

[Alexander Clouter]

Christian Gagneraud <cgagneraud at techworks.ie> wrote:
>
> H Hartley Sweeten wrote:
>
>> On Saturday, October 03, 2009 6:14 PM, Christian Gagneraud wrote:
>>> From: Matthieu Crapet <mcrapet at gmail.com>
>>>
>>> In early days Technologic Systems fixed the 0x163 value in redboot
>>> instead of 0x2a1, this patch allow to overwrite it.
>>>
>>> Signed-off-by: Matthieu Crapet <mcrapet at gmail.com>
>>> Signed-off-by: Christian Gagneraud <cgagneraud at techworks.ie>
>> 
>> As others have already pointed out, this is a pure hack and not
>> suitable for mainline.
>> 
>> The bootloader for systems that needs this really should be updated.
>> Machine ID 0x163 (355) is ARCH_CX861XX which isn't an ep93xx based
>> system and doesn't even have a platform init in mainline.
> 
> I see your point, but what if the bootloader can't be updated? Does 
> that mean that people using these boards will have to bother with 
> applying patches on mainline kernel for ever?
>
The price for buying broken hardware and not grumbling at the venduh.

Fortunately I have already grumbled at TS in the past and they promised 
to fix this for their new boards.

> Can't we find a way to address this issue, I'm pretty sure this is not 
> the only board that need this kind of asm hack.
> 
It's not the only board, but as the 'asm hack' is something that can be 
done in userspace as a post-kernel compiling process.  You have to do 
<something> to get it onto the FLASH of the board, no harm inserting a 
very trivial step.

The moment you start being 'liberal' with machine id's from borkened 
bootloaders you remove the point of having them altogether.  Without 
them you cannot have the same kernel boot *every* ep93xx SoC...

Cheers

-- 
Alexander Clouter
.sigmonster says: BOFH excuse #447:
                  According to Microsoft, it's by design