[PATCH v1.0 2/4] TS72XX: Allow to override machine ID

[Christian Gagneraud]

H Hartley Sweeten wrote:
> On Saturday, October 03, 2009 6:14 PM, Christian Gagneraud wrote:
>> From: Matthieu Crapet <mcrapet at gmail.com>
>>
>> In early days Technologic Systems fixed the 0x163 value in redboot
>> instead of 0x2a1, this patch allow to overwrite it.
>>
>> Signed-off-by: Matthieu Crapet <mcrapet at gmail.com>
>> Signed-off-by: Christian Gagneraud <cgagneraud at techworks.ie>
> 
> As others have already pointed out, this is a pure hack and not
> suitable for mainline.
> 
> The bootloader for systems that needs this really should be updated.
> Machine ID 0x163 (355) is ARCH_CX861XX which isn't an ep93xx based
> system and doesn't even have a platform init in mainline.

I see your point, but what if the bootloader can't be updated? Does 
that mean that people using these boards will have to bother with 
applying patches on mainline kernel for ever?
Can't we find a way to address this issue, I'm pretty sure this is not 
the only board that need this kind of asm hack.

Regards,
Chris

> 
> NAK.
> 
> Regards,
> Hartley