[PATCH] ARM: MX3: fix CPU revision number detection

Daniel Mack daniel at caiaq.de
Tue Nov 24 12:36:57 EST 2009


On Sat, Nov 21, 2009 at 07:22:49PM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 21, 2009 at 07:00:37PM +0000, Russell King - ARM Linux wrote:
> > On Sat, Nov 21, 2009 at 05:19:24PM +0100, Daniel Mack wrote:
> > > +#include <asm/io.h>
> > 
> > I see red.  linux/io.h please.
> 
> BTW, as a reminder, the reason I pick up on these soo much is because
> I've configured my mail client (mutt) to highlight them:
> 
> color body white red "\\+.*(#include <(asm|mach)/(gp)?io\.h>|return -1|default n)"
> 
> which matches new uses of 'asm/io.h', 'mach/io.h', 'asm/gpio.h',
> 'mach/gpio.h', 'return -1' and 'default n' in patches.

That is quite handy, but when my own patches are parsed by mutt, it's
usually too late ;) I'll hack a git-pre-commit script to prevent that in
the future. Or does anyone have that ready yet?

Daniel




More information about the linux-arm-kernel mailing list