[PATCH] ARM: MX3: fix CPU revision number detection

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Nov 21 14:22:49 EST 2009


On Sat, Nov 21, 2009 at 07:00:37PM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 21, 2009 at 05:19:24PM +0100, Daniel Mack wrote:
> > diff --git a/arch/arm/mach-mx3/cpu.c b/arch/arm/mach-mx3/cpu.c
> > new file mode 100644
> > index 0000000..b09f338
> > --- /dev/null
> > +++ b/arch/arm/mach-mx3/cpu.c
> > @@ -0,0 +1,57 @@
> > +/*
> > + * MX3 CPU type detection
> > + *
> > + * Copyright (c) 2009 Daniel Mack <daniel at caiaq.de>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <mach/hardware.h>
> > +#include <mach/iim.h>
> > +#include <asm/io.h>
> 
> I see red.  linux/io.h please.

BTW, as a reminder, the reason I pick up on these soo much is because
I've configured my mail client (mutt) to highlight them:

color body white red "\\+.*(#include <(asm|mach)/(gp)?io\.h>|return -1|default n)"

which matches new uses of 'asm/io.h', 'mach/io.h', 'asm/gpio.h',
'mach/gpio.h', 'return -1' and 'default n' in patches.



More information about the linux-arm-kernel mailing list