IXP4xx: unneeded #include platform-specific include files?

Krzysztof Halasa khc at pm.waw.pl
Sun Nov 15 16:14:56 EST 2009


"Imre Kaloz" <kaloz at openwrt.org> writes:

>> None. Having worked on the Synology DS101 support for mach-ixp4xx
>> I'm 99,99% certain that platform details can and should be private.
>>
>
> Or people can simply stop the #define brain damage and use the GPIO defines.
>
> (hint: IRQ_IXP4XX_GPIO* for PCI stuff, and the gpio number in
> i2c_gpio_platform_data)

I think it's not "or", it's orthogonal to the platforms' private
#defines issue.

Personally I use
#define xgpio_irq(n)            (IRQ_IXP4XX_GPIO ## n)
#define gpio_irq(n)             xgpio_irq(n)
I think we can switch to something similar on other platforms.
-- 
Krzysztof Halasa



More information about the linux-arm-kernel mailing list