IXP4xx: unneeded #include platform-specific include files?

Imre Kaloz kaloz at openwrt.org
Sun Nov 15 15:18:45 EST 2009


On Sun, 15 Nov 2009 19:27:33 +0100, Mikael Pettersson <mikpe at it.uu.se> wrote:

> Krzysztof Halasa writes:
>  > I'm going to move them to the platform code, either incorporate them
>  > into platform .c files or #include "specific-platform.h" from there.
>  >
>  > Objections?
>
> None. Having worked on the Synology DS101 support for mach-ixp4xx
> I'm 99,99% certain that platform details can and should be private.
>

Or people can simply stop the #define brain damage and use the GPIO defines.

(hint: IRQ_IXP4XX_GPIO* for PCI stuff, and the gpio number in i2c_gpio_platform_data)


Imre




More information about the linux-arm-kernel mailing list