[PATCH] pxa/zeus: Allow use of 8250-compatible UART in uncompress

Daniel Mack daniel at caiaq.de
Thu Dec 10 03:19:41 EST 2009


On Thu, Dec 10, 2009 at 09:09:49AM +0100, Marc Zyngier wrote:
> On Thu, 10 Dec 2009 15:12:08 +0800
> Daniel Mack <daniel at caiaq.de> wrote:
> 
> > ... with UART being char* now (and as UART_REG is just a macro) it
> > will only be 8 bits in width, and hence all logic that accesses bits
> > beyond that scope wil fail. Tricky casting might help here, but your
> > referencing that as an array, so the value will be &= 0xff.
> > Or did I overlook anything?
> 
> Well, all registers are actually 8bit wide. So I feel like using char*
> is actually one step closer to the actual behavior of the hardware.
> Unless I in turn overlooked something else... ;-)

Ah ok, I missed that. Would be good to hve a comment stating that, for
the next one to stumble over it :)

Daniel




More information about the linux-arm-kernel mailing list