[PATCH v2 3/3] arm64: dts: amlogic: add T7 peripheral nodes

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: useless regulator properties without gpio
--

commit 61a44d137e93474e04a70d0ea481b570b8e6131c
Author: Xianwei Zhao <xianwei.zhao at amlogic.com>

arm64: dts: amlogic: add T7 peripheral nodes

This patch adds device tree descriptions for the peripherals on the Amlogic
T7 SoC and the T7 A311D2 AN400 board. It introduces support for the T7
Ethernet controller, SPI controllers, I2C controllers, UARTs, pinctrl groups,
regulators, and reserved memory.

> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
> index ca7536f772ff1..50df961fba75b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
> @@ -24,12 +24,159 @@ memory at 0 {

[ ... ]

> +	vddqlp_0v6: regulator-vddqlp-0v6 {
> +		vin-supply = <&dc_in>;
> +		compatible = "regulator-fixed";
> +		regulator-name = "VDDQLP_0V6";
> +		regulator-min-microvolt = <600000>;
> +		regulator-max-microvolt = <600000>;
> +		startup-delay-us = <70000>;
> +		enable-active-high;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};

[Severity: Low]
Is it intentional to include enable-active-high and startup-delay-us
properties for vddqlp_0v6 without defining a control gpio?

Without a gpio defined, the regulator core has no mechanism to toggle the
regulator, meaning enable-active-high has no effect. This appears to be a
device tree schema violation, although it does not cause a failure since the
regulator is marked regulator-always-on.

> +
> +	vdd_ddr: regulator-vdd-ddr {
> +		vin-supply = <&dc_in>;
> +		compatible = "regulator-fixed";
> +		regulator-name = "VDD_DDR";
> +		regulator-min-microvolt = <800000>;
> +		regulator-max-microvolt = <800000>;
> +		startup-delay-us = <70000>;
> +		enable-active-high;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};

[Severity: Low]
Does vdd_ddr also need a control gpio?

Like vddqlp_0v6 above, it specifies enable-active-high and startup-delay-us
but lacks a gpio property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-t7-node-new-v2-0-319d3c19b4b2@amlogic.com?part=3