[PATCH 2/3] dt-bindings: net: meson-dwmac: add T7 support

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: net: meson-dwmac: missing t7-dwmac in select block
- [Medium] dt-bindings: net: meson-dwmac: missing t7-dwmac in generational constraints
--

commit cf2bd16c5188a0d6d2a0e2fdf91dd50ebfa695b8
Author: Xianwei Zhao <xianwei.zhao at amlogic.com>

dt-bindings: net: meson-dwmac: add T7 support

Adds the T7 compatible string to the Meson DWMAC binding and adds a
conditional schema check to enforce the correct compatible combination.

> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> index 5c91716d1f21e..f75a275e2d759 100644
> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> @@ -28,6 +28,18 @@ select:

[Severity: Medium]
Should amlogic,t7-dwmac be added to the select block?

If a node is added with compatible = "amlogic,t7-dwmac";, it appears the
dt-validator will skip this schema entirely if the string is not explicitly
listed in the select properties. This would bypass the new allOf.if rules
added below.

>  
>  allOf:
>    - $ref: snps,dwmac.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: amlogic,t7-dwmac
> +    then:
> +      properties:
> +        compatible:
> +          items:
> +            - const: amlogic,t7-dwmac
> +            - const: amlogic,meson-axg-dwmac
> +            - const: snps,dwmac-4.00

[ ... ]

> @@ -139,8 +151,10 @@ properties:
>            - amlogic,meson-gxbb-dwmac
>            - amlogic,meson-axg-dwmac
>            - amlogic,meson-g12a-dwmac
> +          - amlogic,t7-dwmac

[Severity: Medium]
Does this new compatible string also need to be added to the existing
allOf.if blocks that check for amlogic,meson-axg-dwmac?

Since T7 uses AXG as a fallback, it shares its hardware constraints like
clocks and rx-internal-delay-ps. By omitting amlogic,t7-dwmac from those
existing conditional blocks, the schema implicitly relies on the fallback
string to trigger validation. A missing fallback string in a device tree
would bypass these generational constraints.

>      contains:
>        enum:
> +        - snps,dwmac-4.00
>          - snps,dwmac-3.70a
>          - snps,dwmac

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-t7-node-new-v1-0-e6e0840c1b0b@amlogic.com?part=2