[PATCH v2 1/6] ASoC: dt-bindings: amlogic,gx-audin: add schema

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: amlogic,gx-audin: missing const constraint for #sound-dai-cells
--

commit 1813eec5eb42b623e2aae169825ca6cb3dcd09e8
Author: Valerio Setti <vsetti at baylibre.com>

ASoC: dt-bindings: amlogic,gx-audin: add schema

AUDIN provides I2S audio input support to the Meson GX platforms
(GXBB/GXL).

> diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml
[ ... ]
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:

[Severity: Low]
Should #sound-dai-cells be explicitly defined here with a const constraint?

The binding requires #sound-dai-cells below, but fails to define it in the
properties block with a const constraint. Relying on dai-common.yaml, which
only defines it as true (unconstrained), allows invalid configurations with
incorrect cell counts (e.g., <0> or <2>) to silently pass validation.

> +    items:
> +      - enum:
> +          - amlogic,gxbb-audin
> +          - amlogic,gxl-audin
> +      - const: amlogic,gx-audin
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - resets
> +  - interrupts
> +  - clocks
> +  - "#sound-dai-cells"
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-audin-v2-0-38de4bc1de34@baylibre.com?part=1