[PATCH v2 2/2] arm64: dts: amlogic: add Xiaomi Mi Box 4 support
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Sep 3 01:59:01 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Makefile entries are not alphabetically sorted.
--
commit 70cc330a6bc43bd5cfd305fe463356587a2e4a7d
Author: YuChia-Kan <raspberrykan at stu.hqu.edu.cn>
arm64: dts: amlogic: add Xiaomi Mi Box 4 support
This patch adds initial device tree support for the Xiaomi Mi Box 4, which is
based on the Amlogic S905L SoC. It enables the main on-board peripherals
including eMMC, Wi-Fi, HDMI, USB, and audio.
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 57bc440fa55cc..9f357df5fc54e 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -72,6 +72,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-vero4k.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxlx-s905l-p271.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxlx-mibox4.dtb
[Severity: Low]
Does this break the alphabetical sorting of the dtb list? It looks like
meson-gxlx-mibox4.dtb should be inserted before meson-gxlx-s905l-p271.dtb to
maintain the correct order in the Makefile.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-mibox4-dt-v2-0-fbe7c04472a7@stu.hqu.edu.cn?part=2
More information about the linux-amlogic
mailing list