[DMARC error]Re: [PATCH 0/2] Add PWM support Amlogic S7 S7D S6
Xianwei Zhao
xianwei.zhao at amlogic.com
Tue Mar 31 00:59:03 PDT 2026
Hi George,
On 2026/3/31 15:33, George Stark wrote:
> Hello Martin, Xianwei
>
>
> On 3/31/26 10:10, Xianwei Zhao wrote:
>> Hi Martin,
>> I confirmed with Junyi Zhao that the current implementation counts
>> from zero, so this submission is correct.
>> We agree this should be fixed and will address it in a follow-up patch.
>> Thanks for pointing it out.
>>
>> On 2026/3/31 05:54, Martin Blumenstingl wrote:
>>> Hi Xianwei Zhao,
>>>
>>> thanks for your contribution!
>>>
>>> On Thu, Mar 26, 2026 at 7:35 AM Xianwei Zhao via B4 Relay
>>> <devnull+xianwei.zhao.amlogic.com at kernel.org> wrote:
>>>> Add bindings and driver support Amlogic S7/S7D/S6 SoCs.
>>> There is an old report that got lost, stating that the current
>
> Xianwei Zhao thanks for the confirmation.
> I am the author of the old report and the corresponding patch and it's
> not lost. So if the patch is correct I'll be glad to add relevant
> tested-by tags.
>
I will use your patch and won't send a separate one.
Do you mean I should add a Tested-by tag to your patch?
>>> pwm-meson driver has an off-by-one error with the hi and lo fields:
>>> [0]
>>> Since you are working on bringing up a new platform: is this something
>>> you can verify in your lab?
>>> To be clear: I'm not expecting you to work on this ad-hoc or bring a
>>> patch into this series. However, it would be great if you could verify
>>> if the findings from [0] are correct and send an updated patch in
>>> future.
>>>
>>> Thank you and best regards
>>> Martin
More information about the linux-amlogic
mailing list