[PATCH v8 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Mon Aug 31 01:58:47 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new defconfig entry CONFIG_VIDEO_AMLOGIC_VDEC is not placed in the correct order as it would be generated by `make savedefconfig`.
--
commit c64b548261f0711290a36c1bf013f8ce20bd9e1e
Author: Zhentao Guo <zhentao.guo at amlogic.com>
arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC
This commit enables the Amlogic V4L2 stateless video decoder driver as a
module in the arm64 defconfig to support the Amlogic S4 platform.
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 6ec8d3a69c98e..7be4e5a284bab 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -919,6 +919,7 @@ CONFIG_V4L_PLATFORM_DRIVERS=y
> CONFIG_SDR_PLATFORM_DRIVERS=y
> CONFIG_V4L_MEM2MEM_DRIVERS=y
> CONFIG_VIDEO_AMPHION_VPU=m
> +CONFIG_VIDEO_AMLOGIC_VDEC=m
[Severity: Low]
Is this config placed out of order? In kernel development, defconfig files
must be updated using make savedefconfig to ensure entries are sorted
according to Kconfig parsing order.
In drivers/media/platform/Kconfig, amlogic/Kconfig is sourced before
amphion/Kconfig. Therefore, CONFIG_VIDEO_AMLOGIC_VDEC should appear before
CONFIG_VIDEO_AMPHION_VPU.
Could this be updated via make savedefconfig to avoid deviating from the
strict Kconfig tree order and prevent unnecessary churn or merge conflicts
in the future?
> CONFIG_VIDEO_CADENCE_CSI2RX=m
> CONFIG_VIDEO_WAVE_VPU=m
> CONFIG_VIDEO_E5010_JPEG_ENC=m
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com?part=6
More information about the linux-amlogic
mailing list