[PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding specifies up to 2 interrupts but lacks an 'items' list with descriptions or an 'interrupt-names' property to identify them.
--

commit 96c8a7f3d12fa5059564a56fdedd6a77c76d68cb
Author: Zhentao Guo <zhentao.guo at amlogic.com>

media: dt-bindings: Add Amlogic V4L2 video decoder

Describe the initial support for the V4L2 stateless video decoder driver used
with the Amlogic S4 (S805X2) platform.

> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> new file mode 100644
> index 0000000000000..a93a2140801b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
[ ... ]
> +  reg-names:
> +    items:
> +      - const: dos
> +      - const: dmc
> +
> +  interrupts:
> +    maxItems: 2

[Severity: Low]
Does this properties.interrupts binding allow up to 2 interrupts without
providing an 'items' list with descriptions or an 'interrupt-names' property to
identify them?

Since the driver uses platform_get_irq(pdev, IRQ_VDEC) (where IRQ_VDEC is 1),
it relies strictly on the index order. Could this make the bindings harder to
use correctly and lead to broken interrupts if a device tree author guesses the
wrong order when constructing a new board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com?part=3