[PATCH 1/2] mmc: meson-gx: FIXME: Make sure clk_init_data is fully initialized

Brian Masney bmasney at redhat.com
Mon Aug 24 08:22:31 PDT 2026


On Fri, Aug 21, 2026 at 12:06:03PM +0200, Geert Uytterhoeven wrote:
> The clk_init_data structure contains several mutually-exclusive members
> for different methods to specify the possible parents of a clock,
> prompting drivers to initialize only the members they need.  However,
> not initializing all members may cause subtle issues, which are only
> exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
> 
> Make sure all members are fully initialized, to avoid such bugs, and to
> prevent future breakage when converting drivers to a different method
> for specifying the parents.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>

It looks like the FIXME should be dropped in the commit title? With that
dropped:

Reviewed-by: Brian Masney <bmasney at redhat.com>




More information about the linux-amlogic mailing list