[PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully initialized

[nobuhiro.iwamatsu.x90 at mail.toshiba]

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas at glider.be>
> Sent: Thursday, August 20, 2026 4:05 AM
> To: Tero Kristo <kristo at kernel.org>; Stephen Boyd <sboyd at kernel.org>; Brian
> Masney <bmasney+clk at redhat.com>; Jerome Brunet
> <jbrunet+clk at baylibre.com>; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○Ｃ
> ＰＴ) <nobuhiro.iwamatsu.x90 at mail.toshiba>; Nuno Sa
> <nuno.sa at analog.com>; Guenter Roeck <linux at roeck-us.net>; Michael
> Hennerich <Michael.Hennerich at analog.com>; Antoniu Miclaus
> <antoniu.miclaus at analog.com>; Jonathan Cameron <jic23 at kernel.org>;
> David Lechner <dlechner at baylibre.com>; Andy Shevchenko
> <andy at kernel.org>; Sunny Luo <sunny.luo at amlogic.com>; Xianwei Zhao
> <xianwei.zhao at amlogic.com>; Mark Brown <broonie at kernel.org>; Kees
> Cook <kees at kernel.org>; Kevin Hilman <khilman at baylibre.com>; Mathieu
> Dubois-Briand <mathieu.dubois-briand at bootlin.com>
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> linux-hwmon at vger.kernel.org; linux at analog.com; linux-iio at vger.kernel.org;
> linux-amlogic at lists.infradead.org; linux-spi at vger.kernel.org;
> linux-clk at vger.kernel.org; linux-kernel at vger.kernel.org; Geert Uytterhoeven
> <geert+renesas at glider.be>
> Subject: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully
> initialized
> 
> The clk_init_data structure contains several mutually-exclusive members for
> different methods to specify the possible parents of a clock, prompting drivers
> to initialize only the members they need.  However, not initializing all members
> may cause subtle issues, which are only exposed when
> CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
> 
> visconti_clk_register_gate() fills in init.parent_data, and assumes that
> init.parent_names is NULL.  However, the latter in uninitialized, and thus may
> cause a crash.
> 
> Make sure all members are fully initialized, to fix such bugs, and to avoid future
> breakage when converting drivers to a different method for specifying the
> parents.
> 
> Fixes: b4cbe606dc3674b2 ("clk: visconti: Add support common clock driver
> and reset driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90 at mail.toshiba>

Best regards,
  Nobuhiro