[PATCH v2] spi: meson-spifc: use devm_pm_runtime_set_active_enabled
Felix Gu
ustc.gu at gmail.com
Sat Aug 1 10:51:24 PDT 2026
Use devm_pm_runtime_set_active_enabled to replace
pm_runtime_set_active() + pm_runtime_enable() and drop the out_pm
error label.
Signed-off-by: Felix Gu <ustc.gu at gmail.com>
---
Changes in v2:
- Fix Mark's comment.
- Link to v1: https://patch.msgid.link/20260722-spifc-v1-1-e4462a4c6a06@gmail.com
To: Mark Brown <broonie at kernel.org>
To: Neil Armstrong <neil.armstrong at linaro.org>
To: Kevin Hilman <khilman at baylibre.com>
To: Jerome Brunet <jbrunet at baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
Cc: linux-spi at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-amlogic at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
drivers/spi/spi-meson-spifc.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c
index e36aa94bbdae..82c1c3c0c84b 100644
--- a/drivers/spi/spi-meson-spifc.c
+++ b/drivers/spi/spi-meson-spifc.c
@@ -325,26 +325,20 @@ static int meson_spifc_probe(struct platform_device *pdev)
meson_spifc_hw_init(spifc);
- pm_runtime_set_active(spifc->dev);
- pm_runtime_enable(spifc->dev);
+ ret = devm_pm_runtime_set_active_enabled(spifc->dev);
+ if (ret)
+ return dev_err_probe(spifc->dev, ret, "failed to set runtime PM\n");
ret = devm_spi_register_controller(spifc->dev, host);
- if (ret) {
- dev_err(spifc->dev, "failed to register spi host\n");
- goto out_pm;
- }
+ if (ret)
+ return dev_err_probe(spifc->dev, ret, "failed to register spi host\n");
return 0;
-out_pm:
- pm_runtime_disable(spifc->dev);
-
- return ret;
}
static void meson_spifc_remove(struct platform_device *pdev)
{
pm_runtime_get_sync(&pdev->dev);
- pm_runtime_disable(&pdev->dev);
pm_runtime_put_noidle(&pdev->dev);
}
---
base-commit: 3fe08b9796f36ef437ab9328e7dd1e5ff2d66603
change-id: 20260722-spifc-336fbde9511b
Best regards,
--
Felix Gu <ustc.gu at gmail.com>
More information about the linux-amlogic
mailing list