[PATCH v1] clk: meson: axg-audio: Use dev_err_probe() to simplfy code

Krzysztof Kozlowski krzk at kernel.org
Fri Aug 30 10:46:33 PDT 2024


On 30/08/2024 16:46, Jerome Brunet wrote:
> On Fri 30 Aug 2024 at 16:01, Chen Yufan <chenyufan at vivo.com> wrote:
> 
>> Use dev_err_probe() can make code a bit simpler.
> 
> It surely does but ...
> 
>>
>> Signed-off-by: Chen Yufan <chenyufan at vivo.com>
>> ---
>>  drivers/clk/meson/axg-audio.c | 12 ++++--------
> 
> Why this driver alone ?
> 
> I have nothing against the change you are doing but I would not want to get a
> single patch for each and every amlogic clock drivers.
> 

Look here:
https://lore.kernel.org/all/?q=f:@vivo.com
There is a like a flood of trivial patches started last two weeks. Not
sure if there is any coordination, any oversight or review. Few trivial
ones were introducing bugs, so I suggest caution.

Best regards,
Krzysztof




More information about the linux-amlogic mailing list