[PATCH v2 09/11] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Tue Jan 10 02:17:52 PST 2023
On 09/01/2023 13:53, Neil Armstrong wrote:
> Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs
> to dt-schema.
>
> Take in account the used variant with amlogic,meson-gx-mmc.
>
> Signed-off-by: Neil Armstrong <neil.armstrong at linaro.org>
> ---
> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 75 ++++++++++++++++++++++
> .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 -----------
> 2 files changed, 75 insertions(+), 39 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> new file mode 100644
> index 000000000000..30228964fd9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs
> +
> +description:
> + The MMC 5.1 compliant host controller on Amlogic provides the
> + interface for SD, eMMC and SDIO devices
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong at linaro.org>
> +
> +allOf:
> + - $ref: mmc-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - amlogic,meson-gx-mmc
> + - amlogic,meson-axg-mmc
> + - items:
> + - const: amlogic,meson-gx-mmc
This does not look correct. Either gx is alone (not compatible with
gxbb) or it is compatible with gxbb. Cannot be both.
Best regards,
Krzysztof
More information about the linux-amlogic
mailing list