[PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

Neil Armstrong neil.armstrong at linaro.org
Fri Jan 6 00:13:59 PST 2023


On 05/01/2023 18:52, neil.armstrong at linaro.org wrote:
> On 05/01/2023 13:02, Pierre-Olivier Mercier wrote:
>> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
>>
>> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
>> need to be enabled. This is inherited from the GLX USB design [1].
>>
>> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
>>
>> Signed-off-by: Pierre-Olivier Mercier <nemunaire at nemunai.re>
>> ---
>> v2:
>>   - Fix commit log
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
>>   1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
>> index e3486f60645a..a1f0c38ccadd 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
>> @@ -131,10 +131,6 @@ flash at 0 {
>>   };
>>   &usb {
>> -    phys = <&usb2_phy1>;
>> -    phy-names = "usb2-phy1";
>> -};
>> -
>> -&usb2_phy0 {
>> -    status = "disabled";
>> +    phys = <&usb2_phy0>, <&usb2_phy1>;
>> +    phy-names = "usb2-phy0", "usb2-phy1";
>>   };
> 
> OK weird, this email doesn't appear on any mailing-lists archive, neither our replies !

Seems infradead was struggling yesterday, everything is back to normal and revert is sent to SoC maintainers.

> 
> Neil




More information about the linux-amlogic mailing list