[PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property

Alexander Stein alexander.stein at mailbox.org
Sun Jan 16 01:49:45 PST 2022


Am Samstag, 15. Januar 2022, 16:04:10 CET schrieb Jerome Brunet:
> 
> On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein at mailbox.org> 
wrote:
> 
> > Bindings amlogic,axg-fifo.txt mandates that reset-names is a required
> > property. Add it.
> 
> Binginds *mandates* ?? the bindings you are adding mandates that, not the
> previous doc, nor the driver.

Well, under required properties 'reset-names' is listed as well as 'arb' is 
required, only 'rst' is optional.
So when creating the .yaml accordingly this leads to warnings this patch is 
about to fix.

> Modifying drivers and DT to accomodate made-up bindings requirement is
> disturbing.
> 
> The bindings should not require that because the driver does not, as it
> stands. The driver requires the arb reset to be provided, not the name.
> Please fix the bindings.

Nothing is made up. When creating the .yaml file I took the .txt documentation 
for granted. How should I know the bindings documentation is apparently wrong?

When using your older bindings conversion [1] I'm fine with dropping this one.

Best regards,
Alexander

[1] https://patchwork.kernel.org/project/linux-amlogic/list/?
series=246453&state=%2A&archive=both





More information about the linux-amlogic mailing list